feat: Neovim Configuration Modernization (Phases 1-5)

.github/workflows/ci.yml

@@ -7,7 +7,8 @@ on:
     branches: ["main"]
 
 jobs:
-  check:
+  flake-check:
+    name: "Flake Check"
     runs-on: "ubuntu-latest"
     steps:
       - name: "Checkout repository"
@@ -23,3 +24,34 @@ jobs:
 
       - name: "Run flake check"
         run: "nix flake check"
+
+  neovim-test:
+    name: "Neovim test"
+    runs-on: "ubuntu-latest"
+    steps:
+      - name: "Checkout repository"
+        uses: "actions/checkout@v5"
+
+      - name: "Install Nix"
+        uses: "cachix/install-nix-action@v31"
+        with:
+          extra_nix_config: |
+            experimental-features = nix-command flakes
+            substituters = https://cache.nixos.org https://cache.flox.dev https://devenv.cachix.org
+            trusted-public-keys = cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= flox-cache-public-1:7F4OyH7ZCnFhcze3fJdfyXYLQw/aV7GEed86nQ7IsOs= devenv.cachix.org-1:w1cLUi8dv3hnoSPGAuibQv+f9TZLr6cv/Hm9XgU50cw=
+
+      - name: "Build Neovim configuration"
+        id: "build-neovim"
+        run: |
+          # Build once and capture the output path for reuse in tests
+          NVIM_PATH=$(nix build .#homeConfigurations.floki.config.programs.neovim.finalPackage --accept-flake-config --no-link --print-out-paths --print-build-logs)
+          echo "path=$NVIM_PATH" >> $GITHUB_OUTPUT
+
+      - name: "Run Neovim test suite"
+        run: |
+          # Export the built Neovim to PATH so tests use our custom configuration
+          # The devShell has BATS but not our homeConfiguration's neovim
+          # We reuse the Neovim path from the previous build step (no duplicate build)
+          # Neovim is wrapped with all required tools (rg, fd, lazygit, ncurses) via extraPackages
+          export PATH="${{ steps.build-neovim.outputs.path }}/bin:$PATH"
+          nix develop --command bats scripts/test-neovim.sh

.github/workflows/claude-code-review.yml

@@ -1,22 +1,16 @@
 name: Claude Code Review
 
 on:
-  pull_request:
-    types: [opened, synchronize]
-    # Optional: Only run on specific file changes
-    # paths:
-    #   - "src/**/*.ts"
-    #   - "src/**/*.tsx"
-    #   - "src/**/*.js"
-    #   - "src/**/*.jsx"
+  issue_comment:
+    types: [created]
 
 jobs:
   claude-review:
-    # Optional: Filter by PR author
-    # if: |
-    #   github.event.pull_request.user.login == 'external-contributor' ||
-    #   github.event.pull_request.user.login == 'new-developer' ||
-    #   github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
+    # Only run on PR comments that contain "@claude review" or "claude review"
+    if: |
+      github.event.issue.pull_request &&
+      (contains(github.event.comment.body, '@claude review') ||
+       contains(github.event.comment.body, 'claude review'))
 
     runs-on: ubuntu-latest
     permissions:
@@ -38,7 +32,7 @@ jobs:
           anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
           prompt: |
             REPO: ${{ github.repository }}
-            PR NUMBER: ${{ github.event.pull_request.number }}
+            PR NUMBER: ${{ github.event.issue.number }}
 
             Please review this pull request and provide feedback on:
             - Code quality and best practices

.gitignore

@@ -39,6 +39,7 @@
 /claude/shell-snapshots/
 /claude/statsig/
 /claude/todos/
+/claude/*.md
 
 # Personal TODO tracking
 TODO.md

claude/settings.json

@@ -3,7 +3,6 @@
     "type": "command",
     "command": "bash ~/.claude/statusline-command.sh"
   },
-  "alwaysThinkingEnabled": false,
   "editorMode": "vim",
   "mcpServers": {
     "flox": {

flake.nix

@@ -216,6 +216,26 @@
                   commitizen = {
                     enable = true;
                   };
+                  # Block commits with AI attribution
+                  no-ai-attribution = {
+                    enable = true;
+                    name = "no-ai-attribution";
+                    description = "Block commits with AI attribution footer";
+                    entry = toString (
+                      pkgs.writeShellScript "no-ai-attribution" ''
+                        commit_msg_file="$1"
+                        # Block actual attribution footer (with emoji or https://claude.com link)
+                        if grep -qE "🤖.*Generated.*claude\.com|Co-Authored-By: Claude <" "$commit_msg_file"; then
+                          echo "❌ ERROR: Commit message contains AI attribution footer!"
+                          echo "   Remove '🤖 Generated with [Claude Code](https://claude.com/...)' line."
+                          echo "   Remove 'Co-Authored-By: Claude <noreply@anthropic.com>' line."
+                          echo "   See .claude/CLAUDE.md for commit message guidelines."
+                          exit 1
+                        fi
+                      ''
+                    );
+                    stages = [ "commit-msg" ];
+                  };
                 };
               };
             in
@@ -234,6 +254,7 @@
                     opentofu
                     _1password-cli
                     jq
+                    bats
                   ]
                   ++ pkgs.lib.optionals pkgs.stdenv.isDarwin [ nix-darwin.packages.${system}.default ];
                 shellHook = ''
@@ -306,6 +327,10 @@
         // mkHomeConfiguration {
           system = "aarch64-linux";
           name = "indigo";
+        }
+        // mkHomeConfiguration {
+          system = "x86_64-linux";
+          name = "floki";
         };
       darwinConfigurations =
         { }