Fix s3 event creation using lambda arn #131
Open
smudugal wants to merge 4 commits intogarnaat:developfrom
Open
Fix s3 event creation using lambda arn #131smudugal wants to merge 4 commits intogarnaat:developfrom
smudugal wants to merge 4 commits intogarnaat:developfrom
Conversation
AWS expects ARN as FunctionName parameter on both AddPermission and GetPolicy calls. Using function.name precludes from having different values between function.arn and function.name, lest updates won't work. http://docs.aws.amazon.com/lambda/latest/dg/API_GetPolicy.html http://docs.aws.amazon.com/lambda/latest/dg/API_AddPermission.html Co-authored-by: Ilya Sukhanov <ilya@sukhanov.net>
Use kappa0.7.0 s3 event
Change version back to 0.7.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On lambda policy lookup/update pass function ARN as FunctionName …
AWS expects ARN as FunctionName parameter on both AddPermission
and GetPolicy calls. Using function.name precludes from having
different values between function.arn and function.name, lest
updates won't work.
http://docs.aws.amazon.com/lambda/latest/dg/API_GetPolicy.html
http://docs.aws.amazon.com/lambda/latest/dg/API_AddPermission.html
Co-authored-by: Ilya Sukhanov ilya@sukhanov.net