Skip to content

Conversation

@andrewting19
Copy link
Contributor

@andrewting19 andrewting19 commented Feb 10, 2026

Problem

Switching from a remote SSH session back to a local session could surface a global terminal error in the UI. Stale async SSH attach/start failures were reported after the selection changed, often with sessionId=null.

Fix

  • Add a per-WebSocket attach sequence and ignore stale attach/detach completions.
  • Report terminal attach/start errors against the requested sessionId (not ws.currentSessionId at failure time).
  • Guard terminal output from replaced proxies.
  • Harden Pty/Ssh proxy start/dispose races and make SSH attach use tmux new-session -A to avoid duplicate-session failures.

Testing

  • bun run lint
  • bun run typecheck
  • bun run test

@gbasin gbasin merged commit 590d3d2 into gbasin:master Feb 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants