fix(client): batch scroll wheel input#56
Closed
andrewting19 wants to merge 1 commit intogbasin:masterfrom
Closed
Conversation
Owner
|
Closing — after reviewing the full input path (wheel event → WS send → server dispatch → tmux write), the batching is unlikely to yield a meaningful performance improvement:
The PR also included an unrelated always-on Appreciate the contribution — if you're seeing actual scroll jank we're happy to dig into root causes together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Batch mouse wheel scroll steps into a single
terminal-inputWebSocket message.Why
On fast scrolls the UI was sending one WS message per step, which creates a lot of churn (serialization + WS traffic + backend fanout) and can contribute to jank/low FPS when many sessions are open.
How
ntimes.Tests
bun run lintbun run typecheckbun run test