feat: add support for sentry session replays#24
Open
Conversation
…ec<u8> for raw_body - Changed Docker image tags to use the GitHub Container Registry. - Updated SentryEnvelope struct to store raw_body as Vec<u8> instead of String. - Adjusted related functions to handle byte arrays for improved performance and flexibility. - Modified tests to accommodate changes in envelope structure and ensure proper binary data handling.
- Changed Docker image tags from ghcr.io/flusinerd to sigalen for consistency. - Updated build and push commands in the development documentation.
|
Hi! Could you please clarify why we don’t want to merge this pull request? Is there something about the implementation, compatibility, or long-term maintenance that’s holding us back? |
Author
|
Hey, @sodapng In the meantime you could use my fork: Just need to use the different image. Its identical to this but with the PR merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for replay event tunneling.
Currently this fails with a 400 error because of different amount of lines.
Also the final line is non utf-8 binary data.