fix: clean HTML structure and resolve Prettier CI failures#86
fix: clean HTML structure and resolve Prettier CI failures#86shishir-21 wants to merge 2 commits intogbowne1:masterfrom
Conversation
|
Hi @gbowne1 👋 |
|
I'm not totally sure what to do about the CI. It has several issues but... we need to address the .env-example filename. Theres now several open PRs trying to fix it so its kind of an emergency to fix this issue. Its causing issues in Windows and git. I'm hoping fixing this filename will fix some of the issues. I think I would update the CI configuration. |
|
Got it 👍 |
|
.env PR has been merged. CI fix is likely in #87 by @glenjaysondmello so I would head there first then make appropriate changes to your PR(s) once that's merged @shishir-21 and @Ved178 We're tripping over ourselves due to some issues which should be in the DEVSETUP.MD etc document |
gbowne1
left a comment
There was a problem hiding this comment.
I checked out this change locally for testing and review for merge
It's of my opinion that the correct CI fix is in #87 by @glenjaysondmello
This can wait a little bit to further enhance that PR once it rebased at this point
I'll request changes now pending merge of #87
What this PR does
This PR fixes CI failures caused by invalid HTML structure and formatting issues.
Changes made
npx prettier --check .passes locallyContext
masterResult
✅ Prettier CI checks pass
✅ No HTML syntax errors
✅ Clean, reproducible build