Skip to content

fix: clean HTML structure and resolve Prettier CI failures#86

Open
shishir-21 wants to merge 2 commits intogbowne1:masterfrom
shishir-21:fix/ci-clean-html-prettier
Open

fix: clean HTML structure and resolve Prettier CI failures#86
shishir-21 wants to merge 2 commits intogbowne1:masterfrom
shishir-21:fix/ci-clean-html-prettier

Conversation

@shishir-21
Copy link
Collaborator

What this PR does

This PR fixes CI failures caused by invalid HTML structure and formatting issues.

Changes made

  • Restored valid HTML structure after earlier merge conflicts
  • Ran Prettier across the codebase
  • Verified npx prettier --check . passes locally

Context

  • A previous PR was closed due to a Windows Git limitation involving an invalid filename
  • This PR is recreated from a clean branch based on master

Result

✅ Prettier CI checks pass
✅ No HTML syntax errors
✅ Clean, reproducible build

@shishir-21
Copy link
Collaborator Author

Hi @gbowne1 👋
It looks like the CI checks are failing due to environment-related issues (likely missing env vars / DB connection in CI).
All merge conflicts are resolved on my side.
Could you please advise how you’d like this handled (mock env, skip server start in CI, or CI config update)?
Thanks!

@gbowne1
Copy link
Owner

gbowne1 commented Feb 2, 2026

@shishir-21

I'm not totally sure what to do about the CI. It has several issues but... we need to address the .env-example filename. Theres now several open PRs trying to fix it so its kind of an emergency to fix this issue. Its causing issues in Windows and git. I'm hoping fixing this filename will fix some of the issues.

I think I would update the CI configuration.

@gbowne1 gbowne1 added bug Something isn't working enhancement New feature or request labels Feb 2, 2026
@shishir-21
Copy link
Collaborator Author

@gbowne1

Got it 👍
Agreed — fixing the .env.example filename first makes sense.
Happy to help review or test CI changes once you update the configuration.

@gbowne1
Copy link
Owner

gbowne1 commented Feb 2, 2026

.env PR has been merged.

CI fix is likely in #87 by @glenjaysondmello so I would head there first then make appropriate changes to your PR(s) once that's merged @shishir-21 and @Ved178

We're tripping over ourselves due to some issues which should be in the DEVSETUP.MD etc document

@shishir-21
Copy link
Collaborator Author

@gbowne1

Thanks for the update 👍
Understood — I’ll wait for the CI fixes in #87 and adjust my PR(s) as needed.

@gbowne1
Copy link
Owner

gbowne1 commented Feb 2, 2026

This is going to keep happening if we dont get through all of these PRs then do #78 to separate out main.js into a bunch of different files to separate concernes then further separate the frontend code from the backend code as addressed in #77

Copy link
Owner

@gbowne1 gbowne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out this change locally for testing and review for merge

It's of my opinion that the correct CI fix is in #87 by @glenjaysondmello

This can wait a little bit to further enhance that PR once it rebased at this point

I'll request changes now pending merge of #87

@gbowne1 gbowne1 self-requested a review February 2, 2026 17:22
@shishir-21
Copy link
Collaborator Author

Understood 👍
Agreed that #78 and #77 are key to preventing these recurring issues.
I’m fine waiting on #87 and will rebase/update my PR afterward as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants