Skip to content

fix: configure ESLint environments and resolve CI lint errors#89

Open
shishir-21 wants to merge 5 commits intogbowne1:masterfrom
shishir-21:fix/ci-eslint-env
Open

fix: configure ESLint environments and resolve CI lint errors#89
shishir-21 wants to merge 5 commits intogbowne1:masterfrom
shishir-21:fix/ci-eslint-env

Conversation

@shishir-21
Copy link
Collaborator

What was fixed

  • Configured ESLint to correctly handle Node.js and Service Worker environments
  • Resolved CI-breaking no-undef errors (process, clients)
  • Cleaned up regex escape warning in User model

Result

  • npm run lint now passes (warnings only, no errors)
  • CI pipeline unblocked

No functional changes.

@shishir-21
Copy link
Collaborator Author

Hi @gbowne1 👋

I’ve resolved all ESLint environment and no-undef errors (Node / Service Worker globals), and npm run lint now passes with warnings only.

The remaining CI failures are due to no-console warnings being treated as blocking in CI. There are no functional or syntax issues left.

Before proceeding further, I wanted to confirm your preference:
1️⃣ Should I remove / suppress console.log statements to make CI fully green?
2️⃣ Or is it acceptable to merge with warnings only for now?

Happy to adjust based on your guidance. Thanks!

@gbowne1
Copy link
Owner

gbowne1 commented Feb 2, 2026

@shishir-21 @Ved178

Its okay to merge with warnings this round but now we have a situation where #84 #72 #81 needs fixed and the PR for it merged ASAP as an emergency fix before we get more PRs and also now theres a pile of PRs again.

Please re review that PR and all other open PRs and I'll merge accordingly

@gbowne1 gbowne1 added bug Something isn't working enhancement New feature or request labels Feb 2, 2026
@shishir-21
Copy link
Collaborator Author

@gbowne1
Hello ,
The branch currently contains a file named .env.example: (with a trailing colon),
which causes git pull/rebase to fail on Windows due to NTFS filename restrictions.
Could you please rename it to .env.example?
Happy to update my PR once it’s fixed upstream.

@Ved178
Copy link
Collaborator

Ved178 commented Feb 2, 2026

Hey I resolved the head ref issue with #84 so it's ready to be merged in my opinion.
Will take a look at the other two PRs

@shishir-21 , PR #84 resolves the trailing colon issue.

@shishir-21
Copy link
Collaborator Author

@gbowne1

Thanks for the clarification 👍
Understood — I’ll review the emergency fix PR and the other open PRs shortly.

@gbowne1
Copy link
Owner

gbowne1 commented Feb 2, 2026

@Ved178 @shishir-21

Let's go back and re review all open PRs especially the ones which got rebased.

I have a funny feeling that if we don't #78 soon were going to keep have this same issue

Copy link
Owner

@gbowne1 gbowne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shishir-21
I checked out this change locally for testing and review for merge

This correctly addressed most of the CI issues as far as I can tell.

Approving this PR for merge and merging pending merge of the .env issue PR #84 and further approved review by collaborators and maintainers.

Let's look at doing #78 very soon.

Thanks for the opportunity to review your PR and for your contribution to this project

@gbowne1
Copy link
Owner

gbowne1 commented Feb 2, 2026

I would also review the pr by @glenjaysondmello #87 as it seems to cause the CI to go green

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants