fix: configure ESLint environments and resolve CI lint errors#89
fix: configure ESLint environments and resolve CI lint errors#89shishir-21 wants to merge 5 commits intogbowne1:masterfrom
Conversation
|
Hi @gbowne1 👋 I’ve resolved all ESLint environment and no-undef errors (Node / Service Worker globals), and npm run lint now passes with warnings only. The remaining CI failures are due to no-console warnings being treated as blocking in CI. There are no functional or syntax issues left. Before proceeding further, I wanted to confirm your preference: Happy to adjust based on your guidance. Thanks! |
|
@gbowne1 |
|
Hey I resolved the head ref issue with #84 so it's ready to be merged in my opinion. @shishir-21 , PR #84 resolves the trailing colon issue. |
|
Thanks for the clarification 👍 |
|
Let's go back and re review all open PRs especially the ones which got rebased. I have a funny feeling that if we don't #78 soon were going to keep have this same issue |
gbowne1
left a comment
There was a problem hiding this comment.
@shishir-21
I checked out this change locally for testing and review for merge
This correctly addressed most of the CI issues as far as I can tell.
Approving this PR for merge and merging pending merge of the .env issue PR #84 and further approved review by collaborators and maintainers.
Let's look at doing #78 very soon.
Thanks for the opportunity to review your PR and for your contribution to this project
|
I would also review the pr by @glenjaysondmello #87 as it seems to cause the CI to go green 👀 |
What was fixed
no-undeferrors (process,clients)Result
npm run lintnow passes (warnings only, no errors)No functional changes.