Open
Conversation
- test for new bulletin header while expecting BUFR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
thank you for the useful tool.
We came across this example today which resulted in content of INRS07 RKSL 050900 being written to ISIC20_VGDC_050900.bufr which created issues in our downstream decoding.
In the code there is already a test included if a new header is present while processing until 7777 but this test was not included while checking for BUFR after the header was processed. This pull request adds this test also at this stage of processing.
If you find it useful feel free to merge.
Best regards
Dennis Schulze
MeteoIQ GmbH