Skip to content

Replace oldstyle function definition#96

Open
gruenich wants to merge 2 commits intoge-ne:masterfrom
gruenich:feature/replace-oldstyle-function-defition
Open

Replace oldstyle function definition#96
gruenich wants to merge 2 commits intoge-ne:masterfrom
gruenich:feature/replace-oldstyle-function-defition

Conversation

@gruenich
Copy link
Collaborator

Use C89 style. The old style is no longer allowed with C23.

They are no longer allowed in C23.

Citing the GCC documentation: "An old-style (or “K&R”) function
definition is the way function definitions were written in the
1980s. [..] There is no reason to write a definition this way
nowadays, but they can still be seen in older GNU programs."

https://www.gnu.org/software/c-intro-and-ref/manual/html_node/Old_002dStyle-Function-Definitions.html
@gruenich
Copy link
Collaborator Author

@ge-ne Do you mind having a look?

@ge-ne
Copy link
Owner

ge-ne commented Dec 27, 2025

Sorry for the long silence.

I have thought about the issue and still have concerns about portability and backwards compatibility.
I might freeze the release 2.* and continue with 3.0. Maybe I also might continue to support both branches.
Thus the decision is not easy for me.

Nevertheless a new release is due for beginning of next year. Till then I will have to come to a decision...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants