codenav: Keep "Go to file" dialog open after denying creation of file that wasn't found#1329
Closed
gkatev wants to merge 1 commit intogeany:masterfrom
Closed
codenav: Keep "Go to file" dialog open after denying creation of file that wasn't found#1329gkatev wants to merge 1 commit intogeany:masterfrom
gkatev wants to merge 1 commit intogeany:masterfrom
Conversation
Previously, if the file wasn't found and you replied 'no' to the prompt for creating it, all dialogs closed. This can be annoying in situations where the name/path was entered wrong, and you have to start all over again after receiving the file not found error. This commit allows one to amend the mistake from right where they left off. It was deemed necessary to add GTK_DIALOG_MODAL flag to the dialog creation. Without it, after the repeat gtk_dialog_run call (through the goto), the UI got kinda bugged, with the focus (correctly) being in the dialog, but visually appearing as if it had shifted back to the editor pane.
Contributor
Author
|
Superseded by #1390. |
gkatev
added a commit
to gkatev/geany-plugins
that referenced
this pull request
Nov 27, 2024
… dirs, ~/) PR geany#1390 New features & changes: - The Tab key can now be used to: (Inspired from shells, and GtkFileChooser) - Show the completion list when it's hidden - Trigger an inline completion - Accept a suggested inline completion - Keep dialog open after user denies creation of not-found file (geany#1329) - Allow absolute paths, and recognize ~ as the user's home dir - If no document is open, the current dir is the user's home dir - Show error if the entered path is a directory - Bug fixes, improvements, code formatting fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the file wasn't found and you replied 'no' to the prompt for creating it, all dialogs closed. This can be annoying in situations where the name/path was entered wrong, and you have to start all over again after receiving the file not found error. This commit allows one to amend the mistake from right where they left off.
Demo before:
codenav_goto_before.mp4
Demo after:
codenav_goto_after.mp4