fix xdr parsing of enum, union #1
Conversation
+1.1 - 120730 - beta1 - Rui Xie, Alcatel-Lucent, Inc: + - fix xdr parsing of enum, union + - add feature random encoding for XDR encoding/decoding.
| ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF | ||
| ADVISED OF THE POSSIBILITY OF SUCH DAMAGES. | ||
|
|
||
| $Revision$, Last updated $Date$ |
| ERL = erl | ||
| # | ||
|
|
||
| EBIN=../ebin |
There was a problem hiding this comment.
Please don't submit configs of your build environment upstream
|
|
||
| ../ebin/rpc.app: rpc.app.src | ||
| perl -e $(APPSCRIPT) "$(RPC_VSN)" $(RPC_MODULES) < $< > $@ | ||
|
|
There was a problem hiding this comment.
from the last comment till here, is this an unrelated change?
| if [ ! -f $noxinfile.x ]; then | ||
| echo "Sorry, file $noxinfile.x does not exist" | ||
| if [ ! -f $xfile ]; then | ||
| echo "Sorry, file $xfile does not exist" |
There was a problem hiding this comment.
where does this difference come from?
| %%% Purpose : Port mapper interface | ||
| %%% Created : 14 Aug 1997 by Tony Rogvall <tony@erix.ericsson.se> | ||
| %%% Copyright (c) 2000 Sendmail, Inc. All rights reserved. | ||
| %%% Copyright (c) 2000, 2001 Sendmail, Inc. All rights reserved. |
There was a problem hiding this comment.
where does this difference come from?
| bytes_out = Size, xid = S#state.xid, packet = Call}, | ||
| S1 = S#state{xid = S#state.xid+1, pending = [Pnew|Ps], | ||
| pendinglen = Plen + 1}, | ||
| {noreply, incr_call_stats(S1, Procedure)}. |
There was a problem hiding this comment.
what was the source version this pull request is based on?
It's definitely not the version from git
There was a problem hiding this comment.
Thank you for submitting such a big enhancement!
Though i don't think i'm qualified enough to merge them as i've no way to review the changes for soundness on the logical level.
If i'd do a review just on the syntax alone I don't think this could be merged as is.
Some things to note:
- it seems your submitted pull request is not based on the version from rpc where your git branch is forked of
- you have some suspicious and unrelated changes included
- there are also local build configuration changes for your environment included in the PR
- as other project related files which would have no place upstream, eg. gitattributes, gitignore files) and also superfluous line ending changes.
But even iff you'd change those things and get the PR in a state where it could be merged, i'd still have the problem of missing the knowledge to be able to decide if this a change which should be merged, how/if does it affect current systems and implementations and if this is a feature that should be merged into upstream.
As it stand's now i'm sorry but i can't merge your changes as long as no more knowledgeable person steps forward who can review this change and the PR is cleaned up.
|
Hi gebi, Thanks for review. |
2 participants
+1.1 - 120730 - beta1 - Rui Xie, Alcatel-Lucent, Inc: