Skip to content

Conversation

@tbjers
Copy link
Contributor

@tbjers tbjers commented Oct 10, 2013

Will warn when an adapter is instantiated if its driver is not installed.

Will warn when an adapter is instantiated if its driver is not installed.
@mde
Copy link
Contributor

mde commented Oct 10, 2013

This looks like a solid approach, but with a local install (e.g., if they npm install) inside their app, the require will have to be a 'local require' -- see the requireLocal method here: https://github.com/mde/utilities/blob/master/lib/file.js. We actually used to do this (that's where the requireLocal method originally came from), falling back to looking for an adapter installed directly in Model. But I think we want to assume there's always a local install (i.e., inside the app where somebody's using Model).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants