Router Improvements - Add support for deep nested routers + Session storage fixes#25
Open
amalshehu wants to merge 49 commits intogeekskool:masterfrom
Open
Router Improvements - Add support for deep nested routers + Session storage fixes#25amalshehu wants to merge 49 commits intogeekskool:masterfrom
amalshehu wants to merge 49 commits intogeekskool:masterfrom
Conversation
* redisStore with set and get only * update with master * linting error fixed * fix lint issues * implemented delete in redisStore * some code clean up * bind(this) in session constructor and remove some logs * removed logs * replaced conrtructor with init which is an async function * fix all issues with set, get and delete + DB option as use preference * options and expire time for db entries * support to redis config options such as port and host * update with upstream with new folder structure * update with upstream with new folder structure * await when data from store is a Promise * delete older file to sync with new folder structure * fixed merge conflicts due to changes done to implement signed cookies * restored changes fir redisStore that was discarded to resolve conflict * Mongo Store all operations working * ensure mongodb connection is established before session init * made other store consistant with MongoStore init() signature * code clean up * reverting the test file * reverting package-lock.json * Add mongo and redis in package.json * Modify store database config
* Add mongo and redis in package.json * Modify store database config * Modify session database config * Fix expiry timeout for MemoryStore * Set expiry time for MongoStore
Fix deep nested routers
Fix nested routes chaining issue
amalshehu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.