feat: connect @testplane/testing-library @KuznetsovRoman#45
Merged
KuznetsovRoman merged 8 commits intomasterfrom Sep 24, 2025
Merged
feat: connect @testplane/testing-library @KuznetsovRoman#45KuznetsovRoman merged 8 commits intomasterfrom
KuznetsovRoman merged 8 commits intomasterfrom
Conversation
KuznetsovRoman
force-pushed
the
TESTPLANE-736.testing_library
branch
from
efb7f56 to
6e6d47c
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-736.testing_library
branch
from
6e6d47c to
35c135b
Compare
sipayRT
approved these changes
Sep 24, 2025
src/utils/index.ts
Outdated
| // Find by role | ||
| const fileSearchResultsItems = await fileSearchResults.findAllByRole("option"); | ||
|
|
||
| expect(fileSearchResultsItems.length).toBeGreaterThan(1); |
Member
There was a problem hiding this comment.
лучше везде перед expect добавлять await, чтобы не думать, что вот в этой проверке он не нужен, а в expect(fileSearchResults).toBeDisabled(); обязателен. Лучше сразу пример генерить с await, чтобы никто даже не думал, что можно по-другому
|
|
||
| // Find by placeholder | ||
| const fileSearchInput = await browser.findByPlaceholderText("Search docs"); | ||
| await fileSearchInput.setValue("config"); |
Member
There was a problem hiding this comment.
перед вводом текста я бы еще проверил на видимость элемента - await fileSearchInput.isDisplayedInViewport();
Member
Author
There was a problem hiding this comment.
"isDisplayedInViewport" просто вернет true / false
Добавил "waitForDisplayed"
KuznetsovRoman
force-pushed
the
TESTPLANE-736.testing_library
branch
from
17e1742 to
27d37d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.