Skip to content

Comments

resemble.js updated to 4.1.0#8

Open
DiMurer wants to merge 1 commit intogemini-testing:masterfrom
DiMurer:update-deps-node18-m1
Open

resemble.js updated to 4.1.0#8
DiMurer wants to merge 1 commit intogemini-testing:masterfrom
DiMurer:update-deps-node18-m1

Conversation

@DiMurer
Copy link

@DiMurer DiMurer commented Nov 18, 2022

Fixed error:

OS: M1, MacOS 12.6.1 (21G217)
nodejs: 18.12.1

hermione-reassert-view 4.0.0 -> resemblejs 3.1.0 -> canvas: 2.2.0 ->

In file included from ../src/backend/PdfBackend.h:4:
../src/backend/../closure.h:6:10: fatal error: 'jpeglib.h' file not found
#include <jpeglib.h>

@DiMurer DiMurer force-pushed the update-deps-node18-m1 branch from ff8a1aa to 7e317ba Compare November 18, 2022 13:32
@sipayRT
Copy link
Member

sipayRT commented Nov 18, 2022

hi

tnx for your contribute!
Please, change your commit message to "fix: failed while installing with node@18.x" and I'll merge it

@DiMurer DiMurer force-pushed the update-deps-node18-m1 branch from 7e317ba to 284dcad Compare November 18, 2022 15:52
@DiMurer
Copy link
Author

DiMurer commented Nov 18, 2022

Hi @sipayRT
fixed

@sipayRT
Copy link
Member

sipayRT commented Nov 18, 2022

oh wait.
in major version canvas package was moved to optionalDeps. But how can it work without any canvas dependencies if resemble still use it?

@DiMurer
Copy link
Author

DiMurer commented Nov 18, 2022

oh wait. in major version canvas package was moved to optionalDeps. But how can it work without any canvas dependencies if resemble still use it?

I think that it is explained in readme: rsmbl/Resemble.js@a283db5#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R21

@sipayRT
Copy link
Member

sipayRT commented Nov 18, 2022

try using a previous version of Resemble.js

not bad :)

@sipayRT
Copy link
Member

sipayRT commented Nov 22, 2022

fixed in hermione-reassert-view@4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants