Skip to content

git update bug when destination does not exist [#75] #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
genehack wants to merge 3 commits into
base: main
Choose a base branch
from
Open

git update bug when destination does not exist [#75] #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2e2e8d
Invert the logic here... [#75]
genehack Jul 30, 2024
19c969e
Misc whitespace [#75]
genehack Jul 30, 2024
df17b90
Update .gitignore [#75]
genehack Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
.build
blib
extlib
pm_to_blib
App-GitGot-*
Makefile
Makefile.old
MYMETA.*
!releases/*.tar.gz
24 changes: 12 additions & 12 deletions lib/App/GitGot/Command.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,28 +333,28 @@ sub _git_clone_or_callback {
my( $self , $entry , $callback ) = @_
or die "Need entry and callback";

my $msg = '';

my $msg = '';
my $path = $entry->path;

if ( !-d $path ) {
path($path)->mkpath;

try {
$entry->clone( $entry->repo , './' );
$msg .= $self->major_change('Checked out');
}
if ( -d "$path/.git" ) {
# repo already exists and is checked out, just call the callback
try {
$msg .= $callback->( $msg , $entry );
}
catch { $msg .= $self->error('ERROR') . "\n$_" };
}
elsif ( -d "$path/.git" ) {
else {
# if the directory exists and is non-empty, git will blow up, but that's
# okay. if the directory doesn't exist, git will handle creating it; it
# will also DTRT if the directory is empty and exists
try {
$msg .= $callback->($msg , $entry);
$entry->clone( $entry->repo , $path );
$msg .= $self->major_change('Checked out');
}
catch { $msg .= $self->error('ERROR') . "\n$_" };
}

return $msg;

}

sub _git_fetch {
Expand Down