Skip to content

fix: false warning for empty list of requirements without strategy #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nrfulton merged 3 commits into from
Jan 21, 2026
Merged

fix: false warning for empty list of requirements without strategy #324

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19217b8
fixing a bug that falsely gave a warning when an empty list of requir…
HendrikStrobelt Jan 19, 2026
a165c70
Merge branch 'main' into hen/bugfix_req_check
HendrikStrobelt Jan 20, 2026
7a4a17d
Merge branch 'main' into hen/bugfix_req_check
nrfulton Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mellea/stdlib/functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ async def aact(

if strategy is None:
# Only use the strategy if one is provided. Add a warning if requirements were passed in though.
if requirements is not None and len(requirements) >= 0:
if requirements is not None and len(requirements) > 0:
FancyLogger.get_logger().warning(
"Calling the function with NO strategy BUT requirements. No requirement is being checked!"
)
Expand Down