Open
Conversation
- Files now save to pointer and file folders in the .project folder regardless of where they currently reside.
…itor. - Introduce CSS injection plugin in Vite config for better styling management specifically with the new version of react-player. - Adjust player references to accommodate new methods and ensure compatibility with updated video functionalities.
- Comment out VideoTimelineEditor for now. - Video player prop adjustments.
…ion with audio. - Implement video readiness checks and improve audio URL handling to ensure seamless playback experience stopping errors from race conditions. - Consolidate ReactPlayerRef interface to a type folder.
…o overtop the video for the current file. - Recorded audio adjusts based on timestamp.
…y's as source of truth and extracted it to the old AudioPlayButton.
- Add type safety for contentRef and streamline audio playback handling.
…tab to be able to overlap audio and text. - Suppression of some warnings and errors as they will come if there is no audio to overlap in the previous or next cells.
- Add timestamps to empty cells.
… respective times as well as subtitles.
…aying and vice versa. - Allow for GlobalMessage object to receive full object (including destination used for audioStateChange events)
…exCellEditor and AudioPlayButton
…nd next timestamp information for subtitle files.
- Implemented new message handlers for updating and requesting audio timestamps in the CodexCellEditor. - Added functionality to update audio timestamps in the document model - Enhanced the UI to display audio timestamp sliders for current, previous, and next cells. - Refactored cell conversion logic to include audio timestamps. - Updated types to support audio timestamp data in editor messages and cell content. - Improved audio playback management to synchronize with video playback and handle audio state effectively.
…ead of trying to play 3 different audio elements at once.
- Added functionality to refresh audio timestamps for adjacent cells when their audio attachment state changes. - Implemented initialization of audio timestamps when the Timestamps tab is opened with newly recorded audio. - Improved handling of audio timestamps to ensure synchronization across cells.
…ideo in the timestamps tab.
5 tasks
…ayButtons, opening cells, and pressing play on VideoPlayer.
…ldn't have audio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT NOTE:
pnpm installin the codex/webviews folderpnpm run build:webviewsIf you do not do this, the UI will be messed up.
Video Playback Enhancements
Audio Playback & Synchronization
Ensured:
Timestamp Editing & UI
File Saving & Project Structure Fixes
Exporting
Code Quality & Stability
Added unit and integration tests for audio synchronization logic.