Added revoking of buffers without releasing datastream and functionality to reuse previously announced bufferes#426
Open
eugene-mcn wants to merge 3 commits intogenicam:masterfrom
Open
Added revoking of buffers without releasing datastream and functionality to reuse previously announced bufferes#426eugene-mcn wants to merge 3 commits intogenicam:masterfrom
eugene-mcn wants to merge 3 commits intogenicam:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found an issue where repeated ia.start() and ia.stop() calls would allocate imcreasing amounts of memory. Appears to be from a combination of ia._create_ds_on_connection = True and no call to data_stream.revoke_buffer() being made at acquisition stop.
Have added _reuse_buffers flag and check to announce or revoke buffers if required number of buffers changed.
No tracking of which datastreams own which so will only work with single datastream cameras