*: introduce <pkg> tag for nicer package links #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
ulm
reviewed
Sep 17, 2025
Member
ulm
left a comment
ulm
left a comment
There was a problem hiding this comment.
I'm not yet sure if I like this. The element makes sense, but OTOH DevBook XML is supposed to be simple. So for example we have only a c element instead of code, var, key, path etc.
In any case, if we should accept this, can you please split this into two separate commits, one for the plumbing, and another for the text changes?
| sub = element sub { inline } | ||
| sup = element sup { inline } | ||
| d = element d { empty } | ||
| pkg = element pkg { text } |
Member
There was a problem hiding this comment.
This won't work (and make validate fails) because the element has no parent. It must be added to inline.class (see line 11).
I also wonder whether it should be more general, so we could have <pkg>app-editors/emacs</pkg> or alternatively <pkg name="app-editors/emacs">The One True Editor</pkg>. The uri element does something similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was writing the part for destabaling arch, I noticed we don't have any nice link/render for package (for the text "use qkeyword from app-portage/portage-utils").
I've decided to add a new tag
<pkg>which renders in similar way to how we do it in Gentoo Wiki, with link to packages.g.o, a small nice "package" icon after it.Then I changed all the places where we refer to specific package (and not as just a generic example or source for example). When a reader will want to go to the package page.
@ulm I'm find with rejecting this PR if you think this is useless or not needed.