-
Notifications
You must be signed in to change notification settings - Fork 60
general-concepts/dependencies: mention common pitfalls #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| In <c>PDEPEND</c>, weak blockers act effectively like those in | ||
| <c>RDEPEND</c>, while strong blockers behave more like weak ones because | ||
| satisfaction may be delayed post-install. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's true, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgorny your text states this:
This leaves PDEPEND which is a bit unclear. Again, technically both blocker types are valid. However, weak blockers in PDEPEND would be pretty much equivalent to those in RDEPEND, so there is no reason to use that class. Strong blockers in PDEPEND would logically be equivalent to weak blockers — since the satisfaction of this dependency class can be delayed post install.
Should I just drop this bullet since it is unclear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should drop it. I'm not convinced it's guaranteed.
7e0b300 to
8265f15
Compare
78b2874 to
f29c37c
Compare
f29c37c to
ada5ccc
Compare
ada5ccc to
da3251a
Compare
ulm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
This commit copies from mgorny's blog posts about common pitfalls in writing dependencies, and adds them to the devmanual. Signed-off-by: Michał Górny <mgorny@gentoo.org> Closes: https://bugs.gentoo.org/587526 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
da3251a to
d07b963
Compare
|
@ulm please merge it if you are fine with this PR |
thesamesam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with some comments
|
|
||
| <codesample lang="ebuild" caption="Example of correct use of := outside any-of"> | ||
| IUSE="a b" | ||
| REQUIRED_USE="^^ (a b)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| REQUIRED_USE="^^ (a b)" | |
| REQUIRED_USE="^^ ( a b )" |
| In <c>PDEPEND</c>, weak blockers act effectively like those in | ||
| <c>RDEPEND</c>, while strong blockers behave more like weak ones because | ||
| satisfaction may be delayed post-install. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should drop it. I'm not convinced it's guaranteed.
@thesamesam still had some comments. (@arthurzam: I can apply these two changes when merging if that's o.k.) |
please do, I'm currently resting after returning from military service... |
|
Merged, with the whitespace change applied and the |
This commit copies from @mgorny 's blog posts about common pitfalls in writing dependencies, and adds them to the devmanual.
I've added his sign off (based on https://bugs.gentoo.org/587526#c2) but it might have been wrongly done - but I don't really know the correct way to attribute here (I do want to mention him as the super main source).
Closes: https://bugs.gentoo.org/587526