Skip to content

PB-1968: Update python and packages - #major#39

Merged
msom merged 6 commits intomasterfrom
feat-PB-1968-update-python
Sep 23, 2025
Merged

PB-1968: Update python and packages - #major#39
msom merged 6 commits intomasterfrom
feat-PB-1968-update-python

Conversation

@msom
Copy link
Contributor

@msom msom commented Sep 17, 2025

This PR:

Requires https://github.com/geoadmin/infra-terraform-bgdi/pull/1176

@msom msom force-pushed the feat-PB-1968-update-python branch from f61482b to 70690bb Compare September 17, 2025 12:25
@github-actions github-actions bot changed the title PB-1968: Update python and packages PB-1968: Update python and packages - #minor Sep 17, 2025
@msom msom changed the title PB-1968: Update python and packages - #minor PB-1968: Update python and packages - #major Sep 17, 2025
@msom msom force-pushed the feat-PB-1968-update-python branch from 70690bb to 1fed6ab Compare September 17, 2025 12:28
@msom msom requested a review from rebert September 17, 2025 13:45
@msom msom force-pushed the feat-PB-1968-update-python branch 2 times, most recently from 868d3f1 to ce5718e Compare September 17, 2025 13:54
@msom msom force-pushed the feat-PB-1968-update-python branch from ce5718e to cb1fb53 Compare September 17, 2025 13:58
Makefile Outdated

all: help


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I like the way service-control implemented the help part:
https://github.com/geoadmin/service-control/blob/develop/Makefile#L178

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know this was even possible! I've changed it accordingly...

@rebert rebert requested a review from ltclm September 17, 2025 14:19
Copy link

@rebert rebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci! I'm looking forward to test it's functionality as soon as the new pyi package is there.

Copy link
Contributor

@ltclm ltclm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you 👍

help: ## Display this help
# automatically generate the help page based on the documentation after each make target
# from https://gist.github.com/prwhite/8168133
@awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m\033[0m\n"} /^[$$()% a-zA-Z_-]+:.*?##/ { printf " \033[36m%-15s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awk is great 👍

@msom msom force-pushed the feat-PB-1968-update-python branch from 2cf5c89 to 2f91606 Compare September 23, 2025 05:11
@msom msom merged commit 3e7478e into master Sep 23, 2025
3 checks passed
@msom msom deleted the feat-PB-1968-update-python branch September 23, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants