Skip to content

fixing statement for ddp and pkl path #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kks32 merged 2 commits into from
Nov 11, 2025
Merged

fixing statement for ddp and pkl path #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
144f9e6
fixing statement for ddp and pkl path
Nov 11, 2025
3d4f43a
Format with black
Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions gns/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def predict(device: str, cfg: DictConfig):
example_rollout["loss"] = loss.mean()
filename = f"{cfg.output.filename}_ex{example_i}.pkl"
filename_render = f"{cfg.output.filename}_ex{example_i}"
filename = os.path.join(cfg.output.path, filename_render)
filename = os.path.join(cfg.output.path, f"{filename_render}.pkl")
with open(filename, "wb") as f:
pickle.dump(example_rollout, f)
if cfg.rendering.mode:
Expand Down Expand Up @@ -628,6 +628,7 @@ def train(rank, cfg, world_size, device, verbose, use_dist):
cfg,
rank,
device_id,
use_dist,
)
writer.add_scalar("Loss/valid", valid_loss.item(), step)

Expand Down Expand Up @@ -698,9 +699,15 @@ def train(rank, cfg, world_size, device, verbose, use_dist):
if cfg.training.validation_interval is not None:
sampled_valid_example = next(iter(valid_dl))
epoch_valid_loss = validation(
simulator, sampled_valid_example, n_features, cfg, rank, device_id
simulator,
sampled_valid_example,
n_features,
cfg,
rank,
device_id,
use_dist,
)
if device == torch.device("cuda"):
if use_dist:
torch.distributed.reduce(
epoch_valid_loss, dst=0, op=torch.distributed.ReduceOp.SUM
)
Expand Down Expand Up @@ -807,7 +814,7 @@ def _get_simulator(
return simulator


def validation(simulator, example, n_features, cfg, rank, device_id):
def validation(simulator, example, n_features, cfg, rank, device_id, use_dist):
(
position,
particle_type,
Expand All @@ -830,7 +837,7 @@ def validation(simulator, example, n_features, cfg, rank, device_id):
# Select the appropriate prediction function
predict_accelerations = (
simulator.module.predict_accelerations
if isinstance(device_id, int)
if use_dist
else simulator.predict_accelerations
)
# Get the predictions and target accelerations
Expand Down