added routine to attach file and adjusted function to send message with subject, message and attachment. adjusted global constant.#21
Open
fraurino wants to merge 1 commit intogeoffsmith82:masterfrom
Conversation
…th subject, message and attachment. adjusted global constant.
geoffsmith82
force-pushed
the
master
branch
2 times, most recently
from
52c4c8c to
7a80132
Compare
Owner
|
Thanks for submitting this pull request. In the end, I have basically added your functionality to the code. Your code included a bit much unnecessary changes in the commit, (GMailAuthDemo.dproj - unneeded, EmailOAuthDm.dfm - unneeded. You also included Globals.sample.pas into the project instead of renaming it. I have created the Global.samples.pas file and not included the Globals.pas file (which is in the git .ignore file), so I don't accidentally commit any of my clientid's / secrets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added routine to attach file and adjusted function to send message with subject, message and attachment.
adjusted global constant.