Skip to content

Comments

[Speed] Hackathon speed improvements#96

Draft
LDTalbot wants to merge 4 commits intomasterfrom
speed
Draft

[Speed] Hackathon speed improvements#96
LDTalbot wants to merge 4 commits intomasterfrom
speed

Conversation

@LDTalbot
Copy link
Collaborator

@LDTalbot LDTalbot commented Jan 30, 2025

Description
PR for computational speed improvements during hackathon.

Changes

  • Refactor for updating mass and momentum within single loop & mutex (previous separate update functions still available). Fixes CPU idle time every step when using OpenMP.
  • Test effects with serial
  • Test effects with OpenMP
  • Test effects with MPI
  • Test effects with scaling model size
  • Write tests (current tests cover this)

combines into 1 mutuex; previous separate functions still available
@LDTalbot LDTalbot marked this pull request as draft January 30, 2025 16:49
@LDTalbot LDTalbot self-assigned this Jan 30, 2025
@LDTalbot LDTalbot added the speed Computational cost and speed improvements label Jan 30, 2025
edit bool closed_form in header files to toggle on/off
@LDTalbot LDTalbot changed the title Hackathon speed improvements [Speed] Hackathon speed improvements Apr 16, 2025
left typo correction ✏️
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (c523c20) to head (fa8bbc7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files         244      244           
  Lines       51307    51317   +10     
=======================================
+ Hits        49130    49140   +10     
  Misses       2177     2177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

speed Computational cost and speed improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant