Added timeout capability for IO calls #275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
An important note - this allows a previously-never-encountered |
Author
|
Note test timeouts -- |
martinfleis
reviewed
Dec 19, 2025
Member
martinfleis
left a comment
martinfleis
left a comment
There was a problem hiding this comment.
I'd normally say we should add a test for this but I got no clue how. Any ideas? Otherwise we can just merge as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to permit setting an upper bound on requests, an optional
timeoutparameter is added to the core_retryerfunction, and cascaded upward to all ultimate endpoints.The default value if not specified is
None, which matches the existing functionality.