Switching to installed python when vim is not compiled with +python3

[scarbajali]

I usually work with preinstalled versions of vim which doesn't have +python3 compiled and I see that in this case the plugin is fully disabled.

This PR will switch to the python version installed in the system in case embedded python is not found and only OllamaEdit will be disabled (error messages are displayed if the user tries to use it).

[ilya-bobyr]

A few notes.

[ilya-bobyr]

Looks good to me.
A few minor notes.

[ilya-bobyr]

Considering the same error message is repeated after every invocation to ollama#edit#HasEmbeddedPython() maybe it would make sense to move the error message into the same function?

function! ollama#edit#EnsureEmbeddedPythonIsAvailable() abort
    if exists('g:ollama_embedded_python') && g:ollama_embedded_python != 0
        echoerr "OllamaEdit features require Vim compiled with +python3 support."
        return v:true
    else
        return v:false
    endif
endfunction

And then the usage looks like this:

    if !ollama#edit#EnsureEmbeddedPythonIsAvailable()
        return
    endif

[ilya-bobyr]

minor

In autoload/ollama/setup.vim only the value of g:ollama_embedded_python is checked:

            if g:ollama_embedded_python
              call s:SetupPyVEnv()
            endif

Here both existence and value are checked. While checking existence is more robust, if the assumption is that this value will always be set by the plugin setup code, the existence check becomes redundant.

In any case, it seems inconsistent to treat this variable one way in one location and another way in another.
I think either both locations should check existence, or neither should.
I would probably recommend the latter.
It would make the check simpler.

[ilya-bobyr]

minor

If you are switching to vertical formatting, maybe format all the argument vertically:

Suggested change

	venv_site_packages = os.path.join(
	venv_path,
	'lib', f'python{sys.version_info.major}.{sys.version_info.minor}',
	'site-packages'
	)
	venv_site_packages = os.path.join(
	venv_path,
	'lib',
	f'python{sys.version_info.major}.{sys.version_info.minor}',
	'site-packages'
	)

[ilya-bobyr]

minor

This has been fixed already.
It seems that this project uses merges for PRs, so maybe it does not matter much.
But if you rebase this minor fix should disappear.