Skip to content

Conversation

@owner888
Copy link

@owner888 owner888 commented Dec 1, 2025

for paramters that do not support sampling, replace max_tokens with max_completion_tokens. Remove unsupported parameters such as temperature and top_p.

kaka added 2 commits December 1, 2025 22:26
for paramters that do not support sampling, replace `max_tokens` with `max_completion_tokens`. Remove unsupported parameters such as `temperature` and `top_p`.
@owner888
Copy link
Author

owner888 commented Dec 2, 2025

please check

@gergap
Copy link
Owner

gergap commented Dec 2, 2025

I like the refactoring of FIM prompt building and code fence removing, but something is wrong with the code now.
I tested it and the chat output now removes all the line breaks.

master branch:
chat_before

PR-93:
chat_after

@owner888
Copy link
Author

owner888 commented Dec 3, 2025

let me check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants