Instant: Separate badge variants and use unified atlas#11
Open
broadstone wants to merge 3 commits intogespo89:masterfrom
Open
Instant: Separate badge variants and use unified atlas#11broadstone wants to merge 3 commits intogespo89:masterfrom
broadstone wants to merge 3 commits intogespo89:masterfrom
Conversation
This makes it so that the badges are sorted by their PAX date. A large table is added of all PAX dates, by year, which is used as the sort key for any given PAX badge.
This makes it so that only the needed width is used.
At least for the instant fork, this satisifies Issue gespo89#8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I separated out the badge variants and made them into a unified atlas, but only for the instant version.
Still uses hardcoded years.
It also doesn't restrict you from making impossible badges like a media dev badge.