Skip to content

fixing performance bug in Objective-C implementation #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
getify wants to merge 2 commits into
base: objective-c
Choose a base branch
from
Open

fixing performance bug in Objective-C implementation #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
150f0a2
fixing performance bug (see #64) in Objective-C implementation
getify Dec 15, 2021
de51787
per #64, more performance tweaks
getify Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions NSString+minifyJSONString.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
// Created by Bödecs Tibor on 7/19/13.
// Copyright (c) 2013 Bödecs Tibor. All rights reserved.
//
// Patched by Kyle Simpson, 2021
//

#import "NSString+minifyJSONString.h"

Expand All @@ -20,14 +22,15 @@ - (NSString *)minifyJSONString
NSString *tmp2;
NSMutableArray *new_str = [@[] mutableCopy];
int from = 0;
int prevFrom = 0;
NSString *lc;
NSString *rc;
int lastIndex = 0;

NSRegularExpression *tokenizer = [NSRegularExpression regularExpressionWithPattern:@"\"|(\\/\\*)|(\\*\\/)|(\\/\\/)|\n|\r"
options:NSRegularExpressionCaseInsensitive
error:nil];
NSRegularExpression *magic = [NSRegularExpression regularExpressionWithPattern:@"(\\\\)*$"
NSRegularExpression *magic = [NSRegularExpression regularExpressionWithPattern:@"(\\\\)+$"
options:NSRegularExpressionCaseInsensitive
error:nil];

Expand All @@ -53,12 +56,13 @@ - (NSString *)minifyJSONString
}
[new_str addObject:tmp2];
}
prevFrom = from;
from = lastIndex;

if ( [tmp hasPrefix:@"\""] && !in_multiline_comment && !in_singleline_comment) {
NSArray *_matches = [magic matchesInString:lc
options:0
range:NSMakeRange(0, lc.length)];
range:NSMakeRange(prevFrom, lc.length)];

if (_matches.count > 0 ) {
NSTextCheckingResult *_match = _matches[0];
Expand Down