-
Notifications
You must be signed in to change notification settings - Fork 19
fix(#589): prevent background scroll and browser zooming in full-screen map #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b5bcb15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@garethbowen This is a targeted PR to address background scrolling and zooming issues in full-screen mode. There will be more adjustments to improve the experience, but I wanted to resolve these issues first. I’ve verified the fix on Android, desktop, and iPhone emulators, and Szymon will follow up with a test on a physical iPhone. |
garethbowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. No blockers but I found some niggles during testing on Android Firefox and Chrome.
-
On Mobile Firefox specifically, it's still difficult to scroll past the map when not full screen - the margins are tiny! One fix would be to reduce the maximum height of the map to ~90% of the viewport so you can always grab above or below.
-
The full screen most in landscape on Chrome is a bit ugly...
Notice the big white padding on the left. This doesn't show in Firefox so not sure where it's coming from. This is different from the issue that Szymon found.
- Also in full screen mode we still have rounded corners on the map which is only a few pixels but looks wrong. Change the border radius to 0 so it goes right to the corners of the screen.
| left: 0; | ||
| height: 100vh; | ||
| width: 100vw; | ||
| height: 100dvh; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dynamic nature of this gave me pause because I was worried it might cause too much re-rendering but I couldn't get it to behave poorly either in Chrome or Firefox. Even if it does trigger it feels smooth.
Closes #589
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Manual testing in desktop and mobile devices
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed