fix: normalize domain/email columns with citext #651
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Gupta <yash3144@gmail.com>
yashhhguptaaa
force-pushed
the
fix/citext-domain-normalization
branch
from
8d12e4c to
3c10175
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #603
Changes
auth_saml_configurations.email_domainto CITEXTpeoples.primary_email_addressto CITEXTpeoples.additional_email_addressesto CITEXT[]Why
Domain names and email addresses should be case-insensitive per RFC 1035.
This ensures
Example.COMandexample.comare treated as identical.Testing
Summary by cubic
Make email domains and addresses case-insensitive by converting related columns to CITEXT. This treats Example.COM and example.com as the same to prevent case-related mismatches.
Written for commit 3c10175. Summary will update on new commits.