Refactor(android): Simplify protobuf field checks and fix resource lookup #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LAUNCHPAD-6C. The issue was that: Proto3 scalar field
aapt.pb.Reference.namelacks presence, causingHasField()to fail when not markedoptional.HasField()calls with direct attribute access for protobuf fields (ref.name,ref.id) inproto_xml.pyandproto_xml_drawable_parser.py.src/launchpad/artifacts/android/resources/proto.pyto ensure the correct field is used for retrieval.This fix was generated by Seer in Sentry, triggered by Hector Dearman. 👁️ Run ID: 8393448
Not quite right? Click here to continue debugging with Seer.