test(integration): prevent auto-relaunch on Android #4833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4833 +/- ##
=======================================
Coverage 73.80% 73.80%
=======================================
Files 483 483
Lines 17551 17551
Branches 3461 3461
=======================================
Hits 12954 12954
Misses 3745 3745
Partials 852 852 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the behavior described in #4750 (comment).
Problem
Page.OnAppearingwas originally chosen for triggering test crashes because it seemed like a good place for doing it as soon as the app is visible and fully up and running. However, it turns out to be a bit too early in the sense that it causes Android to try re-launch the process. Each restarted process re-triggers the test crash, which results in intermittent extra envelopes causing test assertion failures.Solution
Delaying the test crash until
VisualElement.Loadedprevents the undesired auto-relaunch behavior on Android.