Skip to content

feat(rebalance): error if a topic migration is ongoing #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmckerry wants to merge 2 commits into from
Closed

feat(rebalance): error if a topic migration is ongoing #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b963143
feat(rebalance): error if a topic migration is ongoing
bmckerry Feb 18, 2025
7b07bb7
better message for slack
bmckerry Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/apply/apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,10 +510,11 @@ func (t *TopicApplier) checkExistingState(
}
}
} else {
log.Warnf(
log.Errorf(
"One or more replicas are not in-sync; there may be an ongoing migration:\n%s",
admin.FormatTopicPartitions(outOfSync, t.brokers),
)
return errors.New("One or more replicas are not in-sync; we are likely horizontally scaling the cluster that this topic is on")
}

return nil
Expand Down