Skip to content

chore: better logging on assignment errors #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmckerry merged 1 commit into from
Apr 24, 2025
Merged

chore: better logging on assignment errors #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/apply/assigners/evaluate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (

"github.com/segmentio/topicctl/pkg/admin"
"github.com/segmentio/topicctl/pkg/config"
log "github.com/sirupsen/logrus"
)

// EvaluateAssignments determines whether the given assignments are consistent
Expand Down Expand Up @@ -61,6 +62,10 @@ func EvaluateAssignments(
brokerRacks := admin.BrokerRacks(brokers)
for _, assignment := range assignments {
if len(assignment.Replicas) != len(assignment.DistinctRacks(brokerRacks)) {
log.Errorf(
"Expected replicas to equal number of racks, but got %d replicas and %d racks for assignment %v",
len(assignment.Replicas), len(assignment.DistinctRacks(brokerRacks)), assignment,
)
return false, nil
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/apply/rebalancers/frequency.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func (f *FrequencyRebalancer) Rebalance(
if err != nil {
return nil, err
} else if !ok {
return nil, fmt.Errorf("Starting assignments do not satisfy placement config")
return nil, fmt.Errorf("starting assignments on topic %s do not satisfy placement config - assignments: %#v", topic, curr)
}

desired := admin.CopyAssignments(curr)
Expand Down