Conversation
|
I don't see any changes you made. Forgot to push? |
I made no changes, answered your question, the info is in the PR. 👍 |
|
I was playing around with this and this worked for me... check : |
# Skip test_tzinfo.py tests - incompatible with system zoneinfo (expect bundled data)
%python3_test pytest3 --ignore=pytz/tests/test_tzinfo.py |
|
Isn't that basically the same as disabling all tests? Or am I thinking of a different file? |
|
Yeah you're right. It does test two other files, docs.py and lazy.py but they're pretty inconsequential for the purpose of the package. So never mind! |
|
Fwiw, I also looked at this a few days ago, but I don't know why the tests fail. I don't really see what we're doing different in our packages than Fedora or Arch that would affect it. |
|
So can this go into now without tests or? |
|
Interestingly I'm also seeing pytz test failures when trying to update edit: Also fails with the old version of edit2: Ah, just saw that something close to this behaviour was already mentioned in this discussion |
|
How about this? The package is testing against the patch, which is isn't expecting. This way it tests with what comes bundled. check : |
export PYTZ_TZDATADIR=pytz/zoneinfo
%python3_test pytest3 |
|
That wouldn't really be testing the package, though, since we're patching it to use the system stuff. Given Fedora also disables the tests that fail with their version of timezone stuff, which I guess is somehow different from ours, we might as well just disable the tests. The last time I went down this rabbit hole, the upstream recommendation for projects is to use the built-in Python APIs in Python 3.9+ and not to use |
**Summary** - Brings the latest IANA 2025b timezone definitions
58b163d to
3147820
Compare
There was a problem hiding this comment.
# Fails using system timezone info
Summary
Test Plan
Checklist
Packaging notes