feat: try upgrade current tag when not matching include-filter #844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Interesting. |
Collaborator
|
May you resolve the conflicts first, please? |
Contributor
Author
Will-do on a later date, as it needs some carefull consideration :) |
PrivatePuffin
force-pushed
the
upgrade-current
branch
from
80475dd to
f777af0
Compare
Contributor
Author
|
I've done some initial rebasing, but would need more checking eye-time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should implement a best-effort attempt at trying to advice upgrading the current tag, if it doesn't match the set include-filter.
But only do so with a semver tag, to prevent unwanted behaviour by it advising moving to completely different containers by accident.
According to current behavior, total tag changes, are already flagged as "major". So this shouldn't cause any significant issues.