feat: Allow disabling Prometheus metrics via env var #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getPrometheusConfiguration function with schema validation - Implement reading of the WUD_PROMETHEUS_ENABLED environment variable with a default value of true - Modify Prometheus module initialization to respect the enablement configuration - Add unit tests for enabled and disabled behavior - Document the new configuration in the monitoring guide in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #766 by addressing the report of idle CPU usage spikes.
To give users more control and resource efficiency, this change introduces a new environment variable
WUD_PROMETHEUS_ENABLED.true(Prometheus enabled).WUD_PROMETHEUS_ENABLED=falseto completely disable the Prometheus module and its background metrics collection.