Adding UI build step into Docker build process #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Attempting to run regex on boolean field: container.image.tag.semver - Throwing instead of returning filtered list of tags
BUG: The logic calling `isDigestToWatch` should pass parsedImage but instead is passing the domain CHANGE: The label `wud.watch.digest` should be respected regardless of registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to get docker-compose trigger working and noticed, that those changes have not yet been released to DockerHub - therefore I needed to build the container locally, when I noticed that the UI is currently not build as one of the build stages (but requires a local build).
Therefore I quickly added an intermediate stage that also builds the UI in Docker to simplify the build and release process.
I've also optimized the overall Dockerfile - let me know if you think I should revert any of those changes:
jqandgit) - I guesstzdataand maybe evenopensslcould be removed as well - but I don't know the app's codebase to have high confidence in this.dockerignoreto enable UI build in Docker containerP.S.: It would be great if you could release a new version - 8.1.1 is 6 months old and I really need the changes to the dockercompose trigger :) Thanks!!!