Migrate UI from JavaScript to TypeScript #900
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert all .js files to .ts - Separate component logic from .vue files into .ts files - Update build configuration (tsconfig, webpack) for TypeScript support - Fix linting and type errors - Update dependencies (jest, typescript-eslint)
- Fix `ts-jest` deprecation warnings by moving `isolatedModules` to `tsconfig.json` and updating `jest.config.js`. - Fix `LoginOidc.spec.ts` by mocking `window.location`. - Fix `AppBar.spec.ts` injection warnings by mocking `vue-router` and updating `v-menu` stub. - Implement comprehensive tests for `HomeView.spec.ts`: - Mock container, registry, trigger, and watcher services. - Verify rendering of status cards and counts. - Test update availability indicators. - Verify navigation links. - Implement comprehensive tests for `LoginView.spec.ts`: - Mock authentication services and strategies. - Test login dialog rendering for Basic and OIDC strategies. - Verify `beforeRouteEnter` logic for anonymous auth and redirects. - Add Jest SVG mock configuration. - Update `setup.ts` stubs (add `v-avatar`, improve `v-btn`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR performs the migration of the
uidirectory from JavaScript to TypeScript,modernizing the codebase with improved type safety and developer experience.
Important
Combined with PR #893 this PR completes the migration of all major areas of this codebase to Typescript.
Key Changes
✨ TypeScript Migration
.jsfiles to.tswith proper ESM imports@ts-nocheckpragmas for gradual migration support🔧 Build & Tooling
ts-jestfor TypeScript test support📦 Development Dependencies
^5.9.3)@types/*packages for all major dependenciests-jestand related toolingTesting
Breaking Changes
None - this is a transparent migration that maintains full backward compatibility.
Migration Strategy
@ts-nocheckcomments where neededWhy This Matters
This migration improves: