[FEATURE] Replace hollabacks with callbacks#33
Open
emschwartz wants to merge 2 commits intogf3:masterfrom
Open
[FEATURE] Replace hollabacks with callbacks#33emschwartz wants to merge 2 commits intogf3:masterfrom
emschwartz wants to merge 2 commits intogf3:masterfrom
Conversation
Chai's `expect` more cleanly handles null and undefined values
Sandbox.run now accepts a callback of the form function(error, result){...}
Sandboxed code's process.stdout is piped directly to parents
Exposed `process.exit()` function to sandboxed code
Added tests
Updated documentation and examples
Bump version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sandbox.run now accepts a callback of the form function(error, result){...}
Sandboxed code's process.stdout is piped directly to parents
Exposed
process.exit()function to sandboxed codeAdded tests
Updated documentation and examples
Changed testing framework to use Chaijs/expect instead of Shouldjs