Skip to content

Conversation

@jjgross77
Copy link

We are adding this as promised

# Make sure 4 - 3 = 1
self.assertEqual(sub(4, 3), 1, 'subtracting three from four')

def test_sub_3arg(self):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any edge cases I had forgotten?

@jjgross77 jjgross77 marked this pull request as ready for review November 30, 2023 21:42
@jjgross77 jjgross77 marked this pull request as draft November 30, 2023 21:42
Adding support for 3rd arg
@jjgross77 jjgross77 marked this pull request as ready for review November 30, 2023 21:48
Copy link
Author

@jjgross77 jjgross77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

return a + b + third_operand

def sub(a, b):
def sub(a, b, c = 0):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def sub(a, b, c = 0):
def sub(a, b, q = 0):

@jjgross77 jjgross77 marked this pull request as draft November 30, 2023 22:07
@jjgross77 jjgross77 marked this pull request as ready for review November 30, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant