Add support for NCCL in communication_object
#195
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t compiles though.
…here is another error.
…NCCL support is enabled
I think that it should be private but currently the test needs them and currently I have no good idea to solve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing to see here yet.
This requires ghex-org/oomph#55 and #190.
Updates
communication_objectto use thestart_group/end_groupfunctionality from oomph/NCCL, as well as takingis_stream_awareinto account.Also does a minor refactoring of packer and communication object helper functions so that the different stages are a bit easier to follow:
If you're already curious to see the changes here, the most useful diff is philip-paul-mueller/GHEX@phimuell__async-mpi-2...msimberg:GHEX:nccl-2.
This replaces #185.