Skip to content

Fixed detect-scheme.sh typo#9

Merged
ericbsd merged 1 commit intomasterfrom
rework-install-station
Sep 24, 2025
Merged

Fixed detect-scheme.sh typo#9
ericbsd merged 1 commit intomasterfrom
rework-install-station

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Sep 24, 2025

Summary by Sourcery

Correct the typo in the disk detection script name and its references

Bug Fixes:

  • Fix script header comment to use 'detect-scheme.sh' instead of 'detect-sheme.sh'
  • Update Python call to reference 'detect-scheme.sh' correctly

@ericbsd ericbsd requested review from a team as code owners September 24, 2025 22:45
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR corrects the “sheme” typo by updating the shell script’s header comment and aligning the script name used in the Python partition utility.

Class diagram for updated get_scheme function usage

classDiagram
class partition {
    +get_scheme(disk: str) str
}
partition : get_scheme() now calls detect-scheme.sh instead of detect-sheme.sh
Loading

File-Level Changes

Change Details Files
Fixed spelling of “scheme” in the shell script’s header comment
  • Replaced “detect-sheme.sh” with “detect-scheme.sh” in the comment line
  • Updated descriptive comment from “Detect a disk sheme” to “Detect a disk scheme”
src/backend-query/detect-sheme.sh
Updated Python code to call correctly named script
  • Changed invocation string from “detect-sheme.sh” to “detect-scheme.sh”
  • Ensured the path remains consistent under the query variable
install_station/partition.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ghostbsd-bot ghostbsd-bot moved this to In Review in Development Tracker Sep 24, 2025
@ericbsd ericbsd merged commit f8afc80 into master Sep 24, 2025
1 of 2 checks passed
@ericbsd ericbsd deleted the rework-install-station branch September 24, 2025 22:45
@github-project-automation github-project-automation bot moved this from In Review to Done in Development Tracker Sep 24, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant