Conversation
Contributor
Reviewer's GuideThis PR upgrades the project’s i18n workflow by removing legacy translation files and scripts, integrating DistUtilsExtra translation build/clean commands, bumping the version, simplifying data file packaging, and updating documentation and helper scripts accordingly. Entity relationship diagram for translation files and packaging changeserDiagram
SETUP {
string name
string version
list data_files
dict cmdclass
}
LOCALE {
string locale_code
string po_file
string mo_file
}
BUILD_MO {
string path
}
SETUP ||--o{ LOCALE : includes
SETUP ||--o{ BUILD_MO : packages
LOCALE ||--o{ BUILD_MO : generates
Class diagram for updated setup.py translation commands integrationclassDiagram
class setup {
+__VERSION__ : str
+PROGRAM_VERSION : str
+datafilelist(installbase, sourcebase)
}
class CreateTranslationCommand {
+run()
}
class UpdateTranslationsCommand {
+run()
}
class build_extra
class build_i18n
class clean_i18n
setup <|-- CreateTranslationCommand
setup <|-- UpdateTranslationsCommand
setup ..> build_extra : uses
setup ..> build_i18n : uses
setup ..> clean_i18n : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ericbsd - I've reviewed your changes and they look great!
Blocking issues:
- Found dynamic content used in a system call. This is dangerous if external data can reach this function call because it allows a malicious actor to execute commands. Use the 'subprocess' module instead, which is easier to use without accidentally exposing a command injection vulnerability. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Security Issues
### Issue 1
<location> `setup.py:81` </location>
<issue_to_address>
**security (python.lang.security.audit.dangerous-system-call-audit):** Found dynamic content used in a system call. This is dangerous if external data can reach this function call because it allows a malicious actor to execute commands. Use the 'subprocess' module instead, which is easier to use without accidentally exposing a command injection vulnerability.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| print(f"Creating new {po_file} for locale '{self.locale}'...") | ||
| os.makedirs(po_dir, exist_ok=True) | ||
| os.system(f'msginit --locale={self.locale} --input={pot_file} --output-file={po_file}') | ||
| os.system(f'msginit --locale={self.locale}.UTF-8 --input={pot_file} --output-file={po_file}') |
Contributor
There was a problem hiding this comment.
security (python.lang.security.audit.dangerous-system-call-audit): Found dynamic content used in a system call. This is dangerous if external data can reach this function call because it allows a malicious actor to execute commands. Use the 'subprocess' module instead, which is easier to use without accidentally exposing a command injection vulnerability.
Source: opengrep
github-project-automation
bot
moved this from In Review
to In Progress
in Development Tracker
github-project-automation
bot
moved this from In Progress
to Done
in Development Tracker
Member
Author
|
Related to ghostbsd/issues#199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Remove legacy translation files and scripts, integrate DistUtilsExtra for internationalization, update translation workflow and configuration, and bump project version to 6.7.
New Features:
Enhancements:
Documentation:
Chores: