Skip to content

Defer imports in setup_system.py to fix circle imports#5

Merged
ericbsd merged 1 commit intomasterfrom
circle-import
Nov 29, 2025
Merged

Defer imports in setup_system.py to fix circle imports#5
ericbsd merged 1 commit intomasterfrom
circle-import

Conversation

@ericbsd
Copy link
Member

@ericbsd ericbsd commented Nov 29, 2025

Summary by Sourcery

Bug Fixes:

  • Resolve circular import errors by moving setup_station view imports into the setup_system function.

@ericbsd ericbsd requested review from a team as code owners November 29, 2025 00:46
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 29, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Moves imports of setup flow classes inside the setup_system function to avoid circular import issues while keeping behavior the same.

File-Level Changes

Change Details Files
Defer imports of setup flow classes to function scope to resolve circular imports while preserving existing setup behavior.
  • Remove top-level imports of setup flow classes that participate in circular dependencies
  • Add equivalent imports inside the setup_system function before any usage of those classes
  • Retain all subsequent calls to Language.save_language and other setup logic unchanged
setup_station/setup_system.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Since these imports were moved into the function to avoid circular dependencies, consider adding a short comment above them explaining that they are intentionally deferred so future refactors don’t move them back to the module level.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since these imports were moved into the function to avoid circular dependencies, consider adding a short comment above them explaining that they are intentionally deferred so future refactors don’t move them back to the module level.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericbsd ericbsd merged commit 5427f04 into master Nov 29, 2025
2 checks passed
@ericbsd ericbsd deleted the circle-import branch November 29, 2025 00:47
@github-project-automation github-project-automation bot moved this from In Review to Done in Development Tracker Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant