Adding filesystems to xpm_package_category#39
Merged
Conversation
Reviewer's Guide by SourceryThis PR adds a new 'filesystems' category icon to the XPM package categories and includes some minor code improvements. The changes primarily involve adding new XPM image data for the filesystems icon, renaming a function to follow Python naming conventions, and bumping the version number. Class diagram for the updated xpm_package_category functionclassDiagram
class xpm_package_category {
+all: List
+filesystems: List
+finance: List
}
note for xpm_package_category "Renamed from xpmPackageCategory to follow Python naming conventions"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @ericbsd - I've reviewed your changes - here's some feedback:
Overall Comments:
- The version bump from 1.7 to 2.0 seems too aggressive for these changes. Consider using a minor version increment instead (e.g. 1.8).
- Please provide more context in the PR description about what problem this solves, rather than just referencing the issue number.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve this issue seen in ghostbsd/issues#195
Summary by Sourcery
Add a new 'filesystems' category to the xpm_package_category function and rename the function for consistency. Update the software version to 2.0 in setup.py.
New Features:
Enhancements: