Fix issue #249: Show removal of package conflicts

[mfjurbala]

Software station fails to show the removal of conflicting packages during new package installation. This was reported in Issue #249. During package installation, removed conflicts are now added to the "REMOVED" list and shown to the user.

Summary by Sourcery

Bug Fixes:

• Fix issue where conflicting packages removed during installation were not shown to the user

[sourcery-ai]

Reviewer's Guide by Sourcery

The pull request addresses issue #249, where the software station failed to display the removal of conflicting packages during new package installations. The changes involve parsing the installation log to identify removed packages and adding them to the 'REMOVED' list, which is then displayed to the user.

Sequence diagram for package installation with conflict removal

sequenceDiagram
    participant User
    participant SoftwareStation
    participant PkgBackend

    User->>SoftwareStation: Initiates package installation
    SoftwareStation->>PkgBackend: Executes pkg install command
    PkgBackend->>PkgBackend: Resolves package conflicts
    PkgBackend->>PkgBackend: Removes conflicting packages
    PkgBackend-->>SoftwareStation: Returns installation log with 'REMOVED' list
    SoftwareStation->>SoftwareStation: Parses installation log
    SoftwareStation->>User: Displays installed and removed packages

Loading

File-Level Changes

Change	Details	Files
Add package removals to the 'REMOVED' list during package installation.	Iterate through the installation log to identify removed packages. Append the names of the removed packages to the pkg_to_remove list.	software_station_pkg.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @mfjurbala - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider refactoring to avoid repeating the same logic for 'REMOVED' and other package types.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ericbsd]

LGTM