Improved deleting old be

[ericbsd]

Summary by Sourcery

Enhancements:

• Introduces a new method should_destroy_be to determine if a boot environment should be destroyed based on its name, active status, and mount point.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new method should_destroy_be to encapsulate the logic for determining whether a Boot Environment (BE) should be destroyed. It refactors the boot environment cleanup logic to use this new method. It also increments the version number of the application.

Sequence diagram for cleaning old boot environment

sequenceDiagram
    participant UpdateStationFrontend
    participant bectl

    loop For each boot environment (be) in bectl.get_be_list()
        UpdateStationFrontend->>UpdateStationFrontend: should_destroy_be(be, today)
        alt should_destroy_be(be, today) == True
            UpdateStationFrontend->>bectl: destroy_be(be.split()[0])
        end
    end

Loading

Updated class diagram for UpdateStationFrontend

classDiagram
    class UpdateStationFrontend {
        +should_destroy_be(be_line: str, today_str: str) bool
    }

    note for UpdateStationFrontend "New method to determine if a Boot Environment should be destroyed"

Loading

File-Level Changes

Change	Details	Files
Introduced a new method should_destroy_be to encapsulate the logic for determining whether a Boot Environment (BE) should be destroyed.	Added a new class method should_destroy_be to determine if a BE should be destroyed. The method checks if the BE is protected (active and mounted at root). The method checks if the BE is marked as 'R' (readonly). The method checks if the BE name contains 'backup', does not contain today's date, and is not marked as 'NR'.	update_station/frontend.py
Refactored the boot environment cleanup logic to use the new should_destroy_be method.	Replaced the inline condition for destroying BEs with a call to self.should_destroy_be.	update_station/frontend.py
Incremented the version number of the application.	Updated the __VERSION__ variable from '6.2' to '6.3'.	setup.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the BE name, active status, and mount point into separate functions for better readability.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}